Open
Conversation
douglaswinter
force-pushed
the
power_term_gen
branch
from
9881c74 to
0ce417b
Compare
Contributor
|
Can you rebase and add to the documentation (create |
c-mita
reviewed
Mar 9, 2018
| sign is determined by start, stop, focus and exponent parameters | ||
| """ | ||
|
|
||
| def __init__(self, axis, units, start, stop, focus, exponent, divisor): |
Contributor
There was a problem hiding this comment.
Should have alternate=False in the parameters.
The new generator produces a line of 1-D points according to the equation: y = A((x-xf)/a)^n + yf The parameter yf acts as a focus point around which the point density will be highest, decreasing as we move away from it. The generator takes the arguments axis, units, start, stop, focus, exponent (n), and divisor (a) - 'start' is used to find xf (where y(xf)=yf): xf = a * nth root(|start - focus|) - 'stop' determines the scan size: size = int(f^-1(stop)) - 'A' will be 1 or -1, determined from start, stop, focus and exponent arguments (the sign of 'a' is ignored) - If the exponent is even, it is assumed that we will pass through the focus point.
douglaswinter
force-pushed
the
power_term_gen
branch
from
c912dbd to
ba7682d
Compare
c-mita
reviewed
Mar 12, 2018
| focus (float): Point of interest which will be most finely sampled | ||
| e.g. 7.112 (for Fe K edge) | ||
| exponent (int): If exponent is even, it is assumed we pass through the focus point. | ||
| divisor (float): Sign will be ignored. |
Contributor
There was a problem hiding this comment.
alternate (bool) missing in argument documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new generator produces a line of 1-D points according to the
equation:
y = A((x-xf)/a)^n + yf
The parameter yf acts as a focus point around which the point density
will be highest, decreasing as we move away from it.
The generator takes the arguments axis, units, start, stop, focus,
exponent (n), and divisor (a)
xf = a * nth root(|start - focus|)
size = int(f^-1(stop))
arguments (the sign of 'a' is ignored)
through the focus point.